Use the server type for insert to cursor position - Githubissues

aws / language-servers

AWS related Language Servers

Apache License 2.0

17 stars 15 forks source link

Use the server type for insert to cursor position #287

Closed makenneth closed 1 month ago

makenneth commented 1 month ago

Problem

insertToCursorPosition message from ui-client is not using the server command type: https://github.com/aws/language-servers/blob/3cef4c0349258d7b3d65bd20ceca615d6acd86ad/chat-client/src/client/chat.ts#L105-L107 This is confusing as the other outgoing events follow the server types.

Please feel free to merge it if it looks good or close it if this PR is not correct.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

makenneth commented 1 month ago

Synced up offline that it will be kept as chat-ui-types for now until insertToCursor can be handled on server side