Send Generic command to new tab if current tab is busy - Githubissues

aws / language-servers

AWS related Language Servers

Apache License 2.0

17 stars 15 forks source link

Send Generic command to new tab if current tab is busy #306

Closed makenneth closed 1 month ago

makenneth commented 1 month ago

Problem

If user has an outgoing request and use the generic commands, the chat history becomes a mess.

Note:

Change sinon.stub -> sandbox.stub in chat.test since there is only a sandbox.restore(), which affected the other test file.
Changed mynah.test to use beforeEach setup as it is difficult to debug shared setup
Clear all tabs after each test since both test files seem to share the same UI (with the same tab limit)

Solution

vscode current opens up a new tab if there is an outgoing request. This PR mimics their behavior.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.