Emit initial add tab event

aws / language-servers

AWS related Language Servers

Apache License 2.0

17 stars 15 forks source link

Emit initial add tab event #324

Closed makenneth closed 2 weeks ago

makenneth commented 2 weeks ago

Description

If toolkit has to keep track of the tabs, it is difficult to do so currently because there isn't an event for the initial tab. So chat-client should emit an event on start up.

I think setting trigger to "click" might make sense, but unsure about this.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

ege0zcan commented 2 weeks ago

Approved with a very small comment, the failing windows tests are being worked on right now so feel free to ignore them.