aws / language-servers

AWS related Language Servers
Apache License 2.0
23 stars 18 forks source link

Ensure unque tab id and allow follow up text to be empty #329

Closed makenneth closed 3 months ago

makenneth commented 3 months ago

Description

This PR has two small fixes:

  1. Unique Tab Id
    • VS has a case where the connection to the server would not close but the UI will get reinitialized. The first tab being constant means user can still access existing session.
  2. Allow follow up text to be empty if explicitly set to "". The default text doesn't fit auth follow up. I think we'd want to it to be empty to sort of match the expected UX (which is a button in chat). Server is already adding a default message for chat

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.