search

aws / lumberyard

Amazon Lumberyard is a free AAA game engine deeply integrated with AWS and Twitch – with full source.
Other
2.03k stars 540 forks source link

Modify waf to build vs solution that actually uses msbuild. #427

Open caseymcc opened 5 years ago

caseymcc commented 5 years ago

Requires setting 'msbuild = True' in user_settings.options under [Visual Studio Project Generator] section

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

AMZN-nggieber commented 5 years ago

Hi @caseymcc, thanks for contributing this to LY we'll take a look at the change.

caseymcc commented 5 years ago

For the CryLegacy gem it links to Lua but all of Lua needs to be linked using extern "C" however I see nothing in the files that is in place to handle that. Lua is included with the pre-processor define LUALIB_API (which is also use in CryLegacy) and if it was set to extern "C" would fix the problem however is only seems possible to set it to extern without modifying the code. How is waf handling this?

caseymcc commented 5 years ago

In CloudGemFramework why does it matter if the build is a project generator? If it is a generator then is includes lmbraws_unsupported.waf_files no matter if aws_native is supported, even though in lumberyard_sdks.py it list project_generator as supporting aws_native. If lmbraws_unsupported.waf is included in the build then there are lots of things that get defined twice.

caseymcc commented 5 years ago

think my frustration level has reached too high, done messing with this for a bit. Need to handle the az_code_gen feature, maybe the last item maybe not. Seems every time I fix something, something else pops up.