Assert fix when setting scrollable entity + avoiding LHS

aws / lumberyard

Amazon Lumberyard is a free AAA game engine deeply integrated with AWS and Twitch – with full source.

Other

2.02k stars 540 forks source link

Assert fix when setting scrollable entity + avoiding LHS #501

Closed CDufour909 closed 3 years ago

CDufour909 commented 4 years ago

Switching scrollable entity leads to asserts in Bus connection code due to the fact that previous handler was not disconnected. So this is a pretty trivial fix.

I also changed the following calls from using the m_scrollableEntity that was just assigned to using the entity is passed as parameter to avoid load-hit-stores.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

AMZN-alexpete commented 3 years ago

Thanks for submitting this fix @CDufour909! We've integrated the change and it will be part of an upcoming release.