Correctly upgrade PhysX mesh asset description

aws / lumberyard

Amazon Lumberyard is a free AAA game engine deeply integrated with AWS and Twitch – with full source.

Other

2.02k stars 539 forks source link

Correctly upgrade PhysX mesh asset description #517

Open yuriy0 opened 3 years ago

yuriy0 commented 3 years ago

Version 1 had an 'export as convex' field which maps to 'export method' in Version 2. The existing version converter does not handle the 'export as convex' field, which causes physx colliders being upgraded from Version 1 to Version 2 to always have the default 'export method'.

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

AMZN-puvvadar commented 3 years ago

Hi @yuriy0 ,

Thanks for the submission! We'll take a look at this enhancement and will update pending evaluation.

oyongzhi commented 3 years ago

Hello yuriy0! We've reviewed your pull request and wanted to let you know we will be incorporating your proposed changes into our next version of the Lumberyard engine. Thank you kindly for contributing to Lumberyard!