search

aws / lumberyard

Amazon Lumberyard is a free AAA game engine deeply integrated with AWS and Twitch – with full source.
Other
2.02k stars 539 forks source link

Wrong PhysX scene query buffer size #522

Open m9co opened 3 years ago

m9co commented 3 years ago

When performing scene query with more requested hits than maximum buffer size, passed buffer size (request.m_maxResults) will be lower than actual buffer size and may cause crashes.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

AMZN-alexpete commented 3 years ago

Thanks for submitting this fix @m9co, we're looking into integrating this.

SergeyAMZN commented 3 years ago

Hello @m9co ! We've reviewed your pull request and wanted to let you know we will be incorporating your proposed changes into our next version of the Lumberyard engine. Thank you kindly for contributing to Lumberyard!

theblooopz commented 3 years ago

You should tag and close PRs you integrate. So that we know which are added and which aren't.

m9co commented 3 years ago

@wcbx should I be doing that with my PRs?

theblooopz commented 3 years ago

@m9co you can do what you want with your branch. I was saying Amazon should close this if they integrated it or at least tag it as integrated. Ideally they would do both.