search

aws / lumberyard

Amazon Lumberyard is a free AAA game engine deeply integrated with AWS and Twitch – with full source.
Other
2.02k stars 539 forks source link

EMotionFX crash when used with replication #533

Open SecretsOTheP opened 3 years ago

SecretsOTheP commented 3 years ago

Issue #, if available: N/A

Description of changes: Fixes an uninitialized variable in an EmotionFX component. (m_animGraphInstance)

This variable will cause a crash, especially in a replicated situation where Activate is not called on this component - as it doesn't use a weak pointer container.

m_animGraphInstance needs to be set to null before being used - otherwise, the pointer will be considered valid memory as it's set to a non-null, garbage memory value by default.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

AMZN-Gene commented 3 years ago

Thanks for the fix! I’ll pass this to the character team for review :)