Closed 32teeth closed 4 weeks ago
Another very important point for these kind of changes that they need UX team approval first before implementing these kind of changes. Previously these kind of changes were caused several unexpected UI behaviors and visual regressions. Unless they're precisely investigated and clearly requested from the UX team, we're not changing behavior or the style of the components. For example, they may prefer to have a tooltip or shorten the placeholder since it already has an ellipsis. Also, there is already an ongoing progress for the discoverability of the features through the welcome message instead of relying on the placeholder of the prompt text.
I would strongly suggest contact with the UX team first, and after that wait until the e2e integration test PR is merged. This change should also require a new/updated e2e tests with golden screenshot comparison. Only with that we can assure that we're not causing any visual regressions or unexpected behaviors.
Another very important point for these kind of changes that they need UX team approval first before implementing these kind of changes.
Is there a best contact for the UX team?
Thanks @dogusata for the intro to the UX/UI creative leads
This is the current behaviour of the GitHub Copilot experience (scrollable input box when empty, place holder only)
The implementation is pretty much a replication of those mechanics (super light weight)
I’d be okay to fast follow with a tooltip, before hand we’d need to assess all the use cases for the tool tip but that’s a tomorrow day kinda discussion
Anyway, thanks for the reflection and remarks, I can do a follow up PR.
I’ll sign up for the Ui discussion next week to identify strategy and next steps
CLosing to rebase and correct merge conflicts
Problem
The text input field in the chat prompt component doesn't allow scrolling when no text is present, causing usability issues. The placeholder text width doesn't adjust dynamically, leading to improper alignment and a poor user experience.
Solution
overflow-x: scroll
property and ensuring scrollbars are hidden when there's no content.getPlaceholderWidth
to dynamically calculate and set the placeholder width based on the text content._chat-prompt-wrapper.scss
to ensure proper handling of the placeholder text width and scrollbar behavior.--mynah-placeholder-width
100%
getPlaceholderWidth
as a subscriber is called, returns and sets value for--mynah-placeholder-width
usingstyle: this.getPlaceholderWidth()
Bonus
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.