search

aws / mynah-ui

https://aws.github.io/mynah-ui/
Apache License 2.0
13 stars 11 forks source link

Empty chat box remained after user selection #77

Closed tincheng closed 1 month ago

tincheng commented 2 months ago

Problem

Amazon Q Code Transform uses the Button feature keepCardAfterClick = false, which was previously working. The last version where it should have been working was around @4.9.2, which was updated in this PR.

Here are how the buttons were configured in aws/aws-toolkit-jetbrain.

Tested with latest @aws/mynah-ui@4.15.2 (verified with npm list @aws/mynah-ui)

https://github.com/user-attachments/assets/7a505092-63e1-4b4e-ba09-d5537879058b

Steps to reproduce the issue

  1. Type /transform in Amazon Q Chat to kickoff transformation
  2. In the chat box for Q - Code transformation, click with Cancel or Confirm.
  3. Observe the issue.

Expected behavior

The chat box should disappear completely. No empty small chat box should remain.

System details

dogusata commented 1 month ago

Seems like issue is already solved with previous remaining card issues:

https://github.com/user-attachments/assets/6c17dea6-8f1c-484e-8f8c-c8bedd4850e7

https://github.com/aws/mynah-ui/releases/tag/v4.14.0