search

aws / mynah-ui

https://aws.github.io/mynah-ui/
Apache License 2.0
13 stars 11 forks source link

fix(tabs): Make max tabs notification dismissible and allow external configuration #80

Closed tverney closed 1 month ago

tverney commented 1 month ago

Problem

Currently the notification for max tabs isn't dismissible. Also, isn't possible the implementation overwrite the defaults (duration / tooltip text).

notification

Solution

Add maxReachedOverlayDuration (to adjust the duration / fallbacks to default 5000) to use as a dismiss duration and noMoreTabsTooltip exposable for messaging configuration.

notification

Note: I've tried to update the changelog with newChange, but doesn't seems to have the script.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

tverney commented 1 month ago

@ege0zcan do you have writes to merge this one? If don't, I can ask someone else in the team. Thanks