search

aws / ota-for-aws-iot-embedded-sdk

MIT License
60 stars 74 forks source link

Fix Block Bitmap Calculation #504

Closed BogdanTheGeek closed 9 months ago

BogdanTheGeek commented 11 months ago

Fixes https://github.com/aws/ota-for-aws-iot-embedded-sdk/issues/503

Description

Multiply buffer size by element size (byte). Maybe this should use sizeof(*pFileBitmap). I am not able to run the unit tests as I only have access to a mac and the unit tests depend on mqueue.h.

Checklist:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

bradleysmith23 commented 10 months ago

Thank you for updating the PR, sorry for the delay. Please take a look at the PR checks and correct the issues, you seem to be missing a closing parentheses on line 2268 in ota.c. Thank you!

BogdanTheGeek commented 10 months ago

Sorry about that, I couldn't run the tests locally.

bradleysmith23 commented 10 months ago

/bot run formatting

bradleysmith23 commented 10 months ago

Sorry about that, I couldn't run the tests locally.

No worries! Thank you for applying the fix. For the remaining checks, I can take a look at them and push a fix if that works with you. I will be away for a few days but will be able to do this later next week.

BogdanTheGeek commented 9 months ago

Hi, is this going to be merged?

bradleysmith23 commented 9 months ago

Hi, @BogdanTheGeek, my apologies for the delay. Reviewing the remaining checks now.