search

aws / pg_tle

Framework for building trusted language extensions for PostgreSQL
Apache License 2.0
337 stars 30 forks source link

Record dependency of default version sql func on the extension #246

Closed imor closed 1 year ago

imor commented 1 year ago

Issue #245

Description of changes: Records dependencies of default version sql functions on the TLE. This fixes failures during pg_dump/pg_restore due to <extensionName>--<defaultVersion>.sql function being created after the extension in pg_dump (see #245 for details).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

adamguo0 commented 1 year ago

Thanks for this fix! Do you mind adding a test? e.g. in 002_pg_tle_dump_restore.pl, though I should note that there's an issue with this test file (https://github.com/aws/pg_tle/issues/249). I can add a test to your PR as well if that's easier

adamguo0 commented 1 year ago

CI failure fixed in https://github.com/aws/pg_tle/pull/250

imor commented 1 year ago

@adamguo0 it would be great if you could add a test as I'm not too good with Perl. I've merged main to fix the CI failure.

adamguo0 commented 1 year ago

Merged from main to fix an earlier issue with 002_pg_tle_dump_restore.pl and added a unit test.