search

aws / pg_tle

Framework for building trusted language extensions for PostgreSQL
Apache License 2.0
337 stars 30 forks source link

Let Postgres start if clientauth hits an error #259

Closed adamguo0 closed 10 months ago

adamguo0 commented 11 months ago

Issue #, if available:

Description of changes: Currently we block Postgres from starting if clientauth cannot initialize its background workers. This causes more downtime and headache than necessary. Instead, use a flag to track whether clientauth hit an error initializing and effectively disable the feature if so, emitting warnings to the database log.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

JohnHVancouver commented 11 months ago

More generally, what's the right behavior? If a user wants to start with client_auth hook and they're relying on this feature to authenticate logins, is there a reason they would want the database to start as opposed to fixing the issue?

adamguo0 commented 10 months ago

Good point, closing this PR