aws / pg_tle

Framework for building trusted language extensions for PostgreSQL
Apache License 2.0
337 stars 30 forks source link

Add author attribution to ndistinct README #260

Open samimseih opened 10 months ago

samimseih commented 10 months ago

Description of changes: Adding missing attribution to the ndistinct README

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

jkatz commented 10 months ago

Have we done this for other examples?

adamguo0 commented 10 months ago

We haven't -- it's not too relevant for our existing examples since to my knowledge they weren't proposed or discussed elsewhere first (though I could be wrong about uuid_v7).

jkatz commented 10 months ago

If we go this route, I think for UUIDv7 we should reference the upstream PostgreSQL thread as this predates the implementation and did inspire our discussion around adding it: https://www.postgresql.org/message-id/CAAhFRxitJv%3DyoGnXUgeLB_O%2BM7J2BJAmb5jqAT9gZ3bij3uLDA%40mail.gmail.com

adamguo0 commented 10 months ago

Makes sense, I can add that to this PR