search

aws / pg_tle

Framework for building trusted language extensions for PostgreSQL
Apache License 2.0
333 stars 31 forks source link

Allow mixed case in pgtle.clientauth_users_to_skip and pgtle.clientauth_databases_to_skip #268

Closed TianzeMYou closed 7 months ago

TianzeMYou commented 7 months ago

Issue #, if available: 265

Description of changes: Allow mixed case in pgtle.clientauth_users_to_skip and pgtle.clientauth_databases_to_skip

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

anth0nyleung commented 7 months ago

Please also remove …th_databases_to_skip from the description of the pr

anth0nyleung commented 7 months ago

It's not very clear to me why we need to move the new tests to a separate file. i dont see a strong reason on why we need to split them into different files for this specific edge case.

adamguo0 commented 7 months ago

Do you mind adding your test case and updating the numbers at the top of the file as well: https://github.com/aws/pg_tle/blob/main/test/t/004_pg_tle_clientauth.pl#L24

anth0nyleung commented 7 months ago

Do you mind adding your test case and updating the numbers at the top of the file as well: https://github.com/aws/pg_tle/blob/main/test/t/004_pg_tle_clientauth.pl#L24

+1 on this

adamguo0 commented 7 months ago

LGTM