search

aws / pg_tle

Framework for building trusted language extensions for PostgreSQL
Apache License 2.0
336 stars 31 forks source link

Refactor typo in 04_hooks.md doc #272

Closed Rajanpandey closed 7 months ago

Rajanpandey commented 7 months ago

Update the SQL command to set enable_clientauth hook in the 2nd example in the hook doc. It has a typo suggesting to activate enable_password_check hook instead.

adamguo0 commented 7 months ago

Good catch! One comment, SELECT pg_catalog.pg_reload_conf() is not sufficient to enable the clientauth feature, instead Postgres needs to be restarted. This is covered in line 352 so I think we can remove the SELECT pg_catalog.pg_reload_conf() line.

Rajanpandey commented 7 months ago

Thanks @adamguo0 ! :D Made the changes. Seems like I got multiple commits, I will do a squash merge so that only 1 commit is shown. (Haven't used github since a while, will figure out my way soon)! :)