search

aws / pg_tle

Framework for building trusted language extensions for PostgreSQL
Apache License 2.0
337 stars 30 forks source link

TAP tests failing since upstream commit d5fd786 #278

Closed adamguo0 closed 5 months ago

adamguo0 commented 5 months ago

Description

TAP tests on PG12 to 15 are failing since the commit that backports the BackgroundPsql test module. https://github.com/postgres/postgres/commit/d5fd7865f068209162130a1a392367bf874b9e4d

Steps to reproduce

Run TAP test against REL_{12, 13, 14, 15}_STABLE.

Expected outcome

TAP tests should pass.

Actual outcome

TAP tests fail with Can't locate PostgreSQL/Test/BackgroundPsql.pm

test/t/001_pg_tle_shared_lib.pl ............... Can't locate PostgreSQL/Test/BackgroundPsql.pm in @INC (@INC contains: /usr/local/pgsql/lib/pgxs/src/makefiles/../../src/test/perl /local/home/
adamguo/dev/pg_tle /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 .) at /usr/local/pgsql/lib/pgxs/sr
c/makefiles/../../src/test/perl/PostgreSQL/Test/Cluster.pm line 116.
BEGIN failed--compilation aborted at /usr/local/pgsql/lib/pgxs/src/makefiles/../../src/test/perl/PostgreSQL/Test/Cluster.pm line 116.
Compilation failed in require at test/t/001_pg_tle_shared_lib.pl line 18.
BEGIN failed--compilation aborted at test/t/001_pg_tle_shared_lib.pl line 18.
test/t/001_pg_tle_shared_lib.pl ............... Dubious, test returned 2 (wstat 512, 0x200)
No subtests run

Analysis

When I tried this on my machine, BackgroundPsql.pm was not installed to the pgxs directory even though it is present in the Postgres source tree:

$ ls postgres/src/test/perl/PostgreSQL/Test
AdjustUpgrade.pm  BackgroundPsql.pm  Cluster.pm  RecursiveCopy.pm  SimpleTee.pm  Utils.pm
$ ls /usr/local/pgsql/lib/pgxs/src/test/perl/PostgreSQL/Test
Cluster.pm  RecursiveCopy.pm  SimpleTee.pm  Utils.pm
adamguo0 commented 5 months ago

Community is adding the missing installation rules to PG12-15 https://www.postgresql.org/message-id/CABOikdOBLm_2dpy8qz%2BzuFZBZGz%3DGJ60%3DgNd%3DvS51Lp2NanwNw%40mail.gmail.com