search

aws / porting-advisor-for-graviton

Apache License 2.0
159 stars 27 forks source link

setup-environment.sh isn't using python3.10 or higher even if it is available in PATH while creating PAG binary #33

Closed santosh-at-github closed 1 year ago

santosh-at-github commented 1 year ago

While trying to create binary for the PAG, I get into errors. When I run "setup-environment.sh" in debug mode (bash -x), I see that it usages default Python version on the instance (python 3.9 in case of Amazon Linux 2023) even if a newer python version (3.11) is available in PATH.

Description of change

//: # Added a code block in setup-environment.sh file to list available python version in PATH and loop through each of it, check if it's version is >=3.10 and use that that as python binary in rest of the script. If none of the python version is >=3.10, throw error.

Issue

PR reviewer notes

//: # NA

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

jamolina commented 1 year ago

@santosh-at-github thank you for your contribution! we will perform our checks and tests and merge it once we finish