aws / postgresql-logfdw

Apache License 2.0
22 stars 6 forks source link

Porting log_fdw to file_fdw #1

Closed kadamnn closed 1 year ago

kadamnn commented 1 year ago

Description of changes:

Initial PR to merge file_fdw and log_fdw

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

davecramer commented 1 year ago

Looks good to me

sharmay commented 1 year ago

Please review these files and fix where appropriate. grep file_fdw -rl

expected/.gitignore
expected/log_fdw.out
regression.diffs
README.md
sql/.gitignore
output/log_fdw.source
input/log_fdw.orig
sharmay commented 1 year ago

Testing commit 2af77110cce25b7a6f88ed85e9ea2289432baf29

make installcheck

/local/home/sharyogi/gitwork/pg-14-inst/lib/postgresql/pgxs/src/makefiles/../../src/test/regress/pg_regress --inputdir=./ --bindir='/local/home/sharyogi/gitwork/pg-14-inst/bin'    --dbname=contrib_regression log_fdw
(using postmaster on Unix socket, port 5414)
============== dropping database "contrib_regression" ==============
DROP DATABASE
============== creating database "contrib_regression" ==============
CREATE DATABASE
ALTER DATABASE
============== running regression test queries        ==============
test log_fdw                      ... FAILED       90 ms

======================
 1 of 1 tests failed. 
======================

The differences that caused some tests to fail can be viewed in the
file "/local/home/sharyogi/gitwork/postgresql-logfdw/regression.diffs".  A copy of the test summary that you see
above is saved in the file "/local/home/sharyogi/gitwork/postgresql-logfdw/regression.out".
[
[regression-diffs.txt](https://github.com/aws/postgresql-logfdw/files/10104854/regression-diffs.txt)
](url)
make: *** [installcheck] Error 1
sharmay commented 1 year ago

Remove all rds/RDS from all files.

davecramer commented 1 year ago

closing in favour of #2