aws / s2n-tls

An implementation of the TLS/SSL protocols
https://aws.github.io/s2n-tls/usage-guide/
Apache License 2.0
4.53k stars 705 forks source link

Identify existing tests and build a matrix for new tests #1754

Closed rday closed 2 years ago

rday commented 4 years ago

Problem

We need a list of existing tests to make sure we don’t lose any coverage with the new framework. Each of these existing tests should have an issue created. We need to track what we are not testing at the same time. This can be done with a matrix.

A tag exists in the public Github repo which identifies new integration tests, and bugs in existing integration tests[0]. We need to make sure these features and bug fixes will be possible to add/fix as we build out the infrastructure.

[0] https://github.com/awslabs/s2n/labels/type%2Fintegration_test

Completion Requirement

  OpenSSL BoringSSL LibreSSL
SSLv3 0 0 0
TLS1.0 0 0 0
TLS1.1 0 0 0
TLS1.2 0 0 0
TLS1.3 0 0 0
zz85 commented 4 years ago

one of the places to look to review which dimensions are tested is https://github.com/awslabs/s2n/blob/4ce3517eaa716ce8f6756e0dea97f9032bfd4664/tests/integration/s2n_handshake_test_s_client.py#L213 https://github.com/awslabs/s2n/blob/4ce3517eaa716ce8f6756e0dea97f9032bfd4664/tests/integration/s2n_handshake_test_s_client.py#L812

rday commented 4 years ago

Integ test parity in order of priority:

goatgoose commented 2 years ago

Support for running v2 tests with different libcryptos was added in #3244. Problems with v2 are being tracked in #3246.