Nix Improvements - Githubissues

aws / s2n-tls

An implementation of the TLS/SSL protocols

https://aws.github.io/s2n-tls/usage-guide/

Apache License 2.0

4.52k stars 705 forks source link

Nix Improvements #3841

Closed harrisonkaiser closed 2 months ago

harrisonkaiser commented 1 year ago

Problem:

With #3824 merged, there are several open problems that need addressing

Not all integ tests run in the dev shell for all platforms

[ ] cross_compatibility. This depends on s2nc_head and s2nd_head, which we don't provide, yet.
[ ] renegotiate_apache. Translate apache2 to apachectl (nix can do the apache config)
[ ] sslyze is only available on x86 with <python3.11, (affecting other upgrade efforts)

Tests that are flaky on arm

[x] happy_path
[x] ocsp
[x] record_padding
[x] renegotiate
[ ] session_resumption
[ ] signature_algorithms
[ ] version_negotiation

Not all integ tests work on arm

[ ] Use pytest to retry flaky tests
[ ] Root cause the failures and iterate on addressing the issues
[ ] Add aws-lc with fips module to the libcrypto list
[ ] ~~Move all test infrastructure inside CMake~~ This is tracked elsewhere, and is underway. (e.g. Valgrind and asan )

Requirements / Acceptance Criteria:

What must a solution address in order to solve the problem? How do we know the solution is complete?

The nix shell is used by developers and the CI and the the codebuild/bin directory can be removed.

dougch commented 1 year ago

2/3 of the aarch64 PRs merged: #4045 and #4043