bindings: Rust bindings openssl-src

[dougch]

Security issue notifications

If you discover a potential security issue in s2n we ask that you notify AWS Security via our vulnerability reporting page. Please do not create a public github issue.

Problem:

Bindings GHA check is failing:

~/work/s2n-tls/s2n-tls/bindings/rust/s2n-tls-sys ~/work/s2n-tls/s2n-tls/bindings/rust ~/work/s2n-tls/s2n-tls
 Downloading crates ...
  Downloaded cc v1.0.79
  Downloaded pkg-config v0.3.26
  Downloaded openssl-sys v0.9.80
  Downloaded jobserver v0.1.25
  Downloaded autocfg v1.1.0
  Downloaded openssl-src v111.25.1+1.1.1t
   Compiling pkg-config v0.3.26
   Compiling autocfg v1.1.0
   Compiling jobserver v0.1.25
   Compiling cc v1.0.79
   Compiling openssl-src v111.25.1+1.1.1t
   Compiling s2n-tls-sys v0.0.25 (/home/runner/work/s2n-tls/s2n-tls/bindings/rust/s2n-tls-sys)
error[E0599]: the method `join` exists for struct `Vec<&OsStr>`, but its trait bounds were not satisfied
   --> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/openssl-src-111.25.1+1.1.1t/src/lib.rs:335:55
    |
335 |                     ar.get_args().collect::<Vec<_>>().join(OsStr::new(" ")),
    |                                                       ^^^^ method cannot be called on `Vec<&OsStr>` due to unsatisfied trait bounds
    |
    = note: the following trait bounds were not satisfied:
            `[&OsStr]: Join<_>`

error[E0599]: the method `join` exists for struct `Vec<&OsStr>`, but its trait bounds were not satisfied
   --> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/openssl-src-111.25.1+1.1.1t/src/lib.rs:344:59
    |
344 |                     ranlib.get_args().collect::<Vec<_>>().join(OsStr::new(" ")),
    |                                                           ^^^^ method cannot be called on `Vec<&OsStr>` due to unsatisfied trait bounds
    |
    = note: the following trait bounds were not satisfied:
            `[&OsStr]: Join<_>`

For more information about this error, try `rustc --explain E0599`.
error: could not compile `openssl-src` due to 2 previous errors
warning: build failed, waiting for other jobs to finish...
error: build failed

Solution:

WIP

Requirements / Acceptance Criteria:

What must a solution address in order to solve the problem? How do we know the solution is complete?

• RFC links: Links to relevant RFC(s)
• Related Issues: Link any relevant issues
• Will the Usage Guide or other documentation need to be updated?
• Testing: How will this change be tested? Call out new integration tests, functional tests, or particularly interesting/important unit tests.
  • Will this change trigger SAW changes? Changes to the state machine, the s2n_handshake_io code that controls state transitions, the DRBG, or the corking/uncorking logic could trigger SAW failures.
  • Should this change be fuzz tested? Will it handle untrusted input? Create a separate issue to track the fuzzing work.

Out of scope:

Is there anything the solution will intentionally NOT address?

[dougch]

First failure observed at 2023-02-27 1900 PT, Released ~19 hours ago (1500 PT) https://crates.io/crates/openssl-src/111.25.1+1.1.1t - Timing lines up

[dougch]

resolved with 1.63