search

aws / s2n-tls

An implementation of the TLS/SSL protocols
https://aws.github.io/s2n-tls/usage-guide/
Apache License 2.0
4.49k stars 704 forks source link

Remove external HTTP request from hyper crate tests #4631

Open goatgoose opened 2 months ago

goatgoose commented 2 months ago

Problem:

To avoid complicating the initial hyper crate PR with a localhost testing framework, a test was added that makes an HTTP request to an external source. This introduces potential flakiness, since requests to external sources aren't reliable.

Solution:

Remove the external HTTP request after localhost testing can be performed.

jmayclin commented 2 months ago

I know that the external HTTP request stuff is a bit tedious, but it is a really nice integration test to have. Maybe if it's a matter of trading off, we could deprecate the "well-known endpoints" integration test and move all of that to a similar integration test relying on s2n-tls-hyper?