Open jouho opened 1 week ago
I'd like to run runFuzzTest.sh locally, using the syntax it'll be called with...
You could run the same command we have in buildspec_fuzz.yml
, which is
cmake . -Bbuild \
-DCMAKE_PREFIX_PATH=/usr/local/$S2N_LIBCRYPTO \
-DS2N_FUZZ_TEST=on
Then
cmake --build ./build -- -j $(nproc)
And then
cmake --build build/ --target test -- ARGS="-L fuzz --output-on-failure"
Resolved issues:
awslc
andopenssl-3.0
. This PR adds additional supported libcrypto versions to increase coverage.tests/fuzz
andtests/fuzz/LD_PRELOAD
folders. We should follow cmake build idioms (w.r.t binary location & library location)Description of changes:
Added
openssl-1.0.2
andopenssl-1.1.1
to thes2nFuzzBatch
job.Modified CMakeLists.txt to remove logic that generates test binaries and library files in specific folders. Now, when compiling fuzz tests:
s2n-tls/build/lib
s2n-tls/build/bin
.Updated
runFuzzTest.sh
to adjust the file paths accordingly.Call-outs:
I attempted to add
awslc-fips
to the batch job, but it failed during the compile. Link to Failed CodeBuild job I also triedawslc-fips-2022
, which compiled successfully but failed to find the libcrypto. Link to CodeBuild jobI have created new issue to investigate this: https://github.com/aws/s2n-tls/issues/4800
After this PR is merged, I will also update
s2nOmnibus
to include these libcrypto versions to ensure that the patches won’t break anything.Testing:
Tested by overriding s2nFuzzBatch job against this PR, and they are finding correct libcrypto versions: Link to CodeBuild job
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.