aws / s2n-tls

An implementation of the TLS/SSL protocols
https://aws.github.io/s2n-tls/usage-guide/
Apache License 2.0
4.52k stars 704 forks source link

Revert "test: disallow explict use of "default" policy in tests (#4750)" #4812

Closed toidiu closed 1 day ago

toidiu commented 1 day ago

This reverts commit 360feb238fcd2b03efe7a8025708b32890bae811.

Description of changes:

While executing the plan to auto-pin config/connection to a numbered policy, we discovered that some tests in-fact do want to test the "default" policy. This means that pinning these policies would result in testing regression.

The same reasoning also applies to the explicit usage in our tests and we need to carefully audit those tests before pinning those policies. This PR reverts the pinning the explicit usage until we have a clear path forward and we can carefully audit those tests.

Testing:

CI should continue to pass

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.