Open jmayclin opened 1 day ago
DS2N_BLOCK_NONPORTABLE_OPTIMIZATIONS is not referenced anywhere in the codebase. Setting it to true or false is a no-op and does not change anything.
DS2N_BLOCK_NONPORTABLE_OPTIMIZATIONS
This was previously used for the s2n-tls copy of pq stuff but now that the PQ code has been moved to AWS-LC the compile definition is unused.
I grep'd through our codebase for S2N_BLOCK_NONPORTABLE_OPTIMIZATIONS and removed all references to it.
S2N_BLOCK_NONPORTABLE_OPTIMIZATIONS
All CI should pass.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description of changes:
DS2N_BLOCK_NONPORTABLE_OPTIMIZATIONSis not referenced anywhere in the codebase. Setting it to true or false is a no-op and does not change anything.This was previously used for the s2n-tls copy of pq stuff but now that the PQ code has been moved to AWS-LC the compile definition is unused.
I grep'd through our codebase for
S2N_BLOCK_NONPORTABLE_OPTIMIZATIONSand removed all references to it.Testing:
All CI should pass.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.