search

aws / sagemaker-chainer-container

Docker container for running Chainer scripts to train and host Chainer models on SageMaker
Apache License 2.0
18 stars 26 forks source link

Upgrade to python3.6 #72

Closed icywang86rui closed 5 years ago

icywang86rui commented 5 years ago

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

ChoiByungWook commented 5 years ago

How you tested this image with the example notebooks?

icywang86rui commented 5 years ago

I have tested all 4 notebooks by overriding the image uri. They all passed except for the local mode one. Because we changed the behavior of local mode it's unrelated to the python version upgrade. I merged in a change to fix that - https://github.com/awslabs/amazon-sagemaker-examples/pull/696

ChoiByungWook commented 5 years ago

Were you able to successfully rerun the failing local mode notebook?

icywang86rui commented 5 years ago

yes. the notebook runs now.