aws / sagemaker-experiments

Experiment tracking and metric logging for Amazon SageMaker notebooks and model training.
Apache License 2.0
125 stars 36 forks source link

retry association tests #145

Closed danabens closed 2 years ago

danabens commented 2 years ago

there was a previous failure, add retry.

Testing

tox -e py37 -- tests/integ/test_tracker.py -m 'not docker'

earlier failure:

trial_component_obj = TrialComponent(sagemaker_boto_client=<botocore.client.SageMaker object at 0x7fab5a3270f0>,trial_component_name='smexpe...: 'application/x-amz-json-1.1', 'content-length': '148', 'date': 'Wed, 13 Oct 2021 20:27:00 GMT'}, 'RetryAttempts': 0})
bucket = 'sagemaker-experiments-integ-test-us-west-2-XXXXXXXX
sagemaker_boto_client = <botocore.client.SageMaker object>

    def test_log_table_artifact(trial_component_obj, bucket, sagemaker_boto_client):

        prefix = name()
        artifact_name = "TestTableTitle"

        values = {"x": [1, 2, 3], "y": [4, 5, 6]}

        with tracker.Tracker.load(
            trial_component_obj.trial_component_name,
            artifact_bucket=bucket,
            artifact_prefix=prefix,
            sagemaker_boto_client=sagemaker_boto_client,
        ) as tracker_obj:
            tracker_obj.log_table(title=artifact_name, values=values)

        response = sagemaker_boto_client.list_associations(SourceArn=trial_component_obj.trial_component_arn)
        associations = response["AssociationSummaries"]
>       assert len(associations) == 1
E       assert 0 == 1
E        +  where 0 = len([])

tests/integ/test_tracker.py:180: AssertionError
jiahaoli97 commented 2 years ago

LGTM