search

aws / sagemaker-experiments

Experiment tracking and metric logging for Amazon SageMaker notebooks and model training.
Apache License 2.0
125 stars 36 forks source link

Make skip slow tests the default behavior #48

Closed l2yao closed 4 years ago

l2yao commented 4 years ago

Issue #, if available: running slow tests as a default now

Description of changes: make skip slow tests the default behavior

Testing done: tox

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

danabens commented 4 years ago

how are you running tests currently? this is already the default behavior if you are using tox https://github.com/aws/sagemaker-experiments/blob/master/tox.ini#L52

l2yao commented 4 years ago

how are you running tests currently? this is already the default behavior if you are using tox https://github.com/aws/sagemaker-experiments/blob/master/tox.ini#L52

Yes, this is meant for the case of running pytest directly

danabens commented 4 years ago

update the tox ini then so we are not controlling slow test runs in two difference places

https://github.com/aws/sagemaker-experiments/blob/master/tox.ini#L52 https://github.com/aws/sagemaker-experiments/blob/master/tox.ini#L98

l2yao commented 4 years ago

update the tox ini then so we are not controlling slow test runs in two difference places

https://github.com/aws/sagemaker-experiments/blob/master/tox.ini#L52 https://github.com/aws/sagemaker-experiments/blob/master/tox.ini#L98

Done, here is the Action workflow run successfully for integ tests: https://github.com/l2yao/sagemaker-experiments/runs/423874849?check_suite_focus=true