Closed choukit closed 1 year ago
Can you help me understand how "The workflow would be triggered to check for any regression on PR submission only if the PR submission has been approved by the admin"?
Does this mean if any of us has to approve the PR first. Is it possible that such a workflow would be misused by any of the forked github repo created by any user?
Github workflows support approvals. The approval here means the approval for running the workflow. Consider the following sequence for better understanding
So workflow can not be misused as it can not run without Admin approval. Additionally if the user attempts to run it on forked repo or outside of the original repo, it won't be able to run anything against the AWS account. The role is stored in gtihub secrets which is not accessible to the forked repo
This change adds workflow for building the library on pull request submission and running the integration tests. The workflow would be triggered to check for any regression on PR submission only if the PR submission has been approved by the admin.
Description of changes:
Added a build(build.yml) workflow which gets triggered on PR submission. This workflow builds the library and runs the unit tests. Along with it, it also creates and uploads the artifacts which would be used by the integ test workflow.
Added an integration tests workflow(integration-tests.yml) which gets triggered on successful completion of build workflow. This workflow downloads the build artifact uploaded in the build workflow and runs integration tests on them.
Testing done:
Tested the workflow triggers on the forked repository and verified that the corresponding workflows get triggered
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.