aws / sagemaker-inference-toolkit

Serve machine learning models within a 🐳 Docker container using 🧠 Amazon SageMaker.
Apache License 2.0
391 stars 82 forks source link

Warning: "Calling MMS with mxnet-model-server. Please move to multi-model-server." #69

Open mb-dev opened 4 years ago

mb-dev commented 4 years ago

Describe the bug When deploying sagemaker endpoint using the example dockerfile: https://github.com/awslabs/amazon-sagemaker-examples/tree/master/advanced_functionality/multi_model_bring_your_own we now get the above warning "Calling MMS with mxnet-model-server. Please move to multi-model-server."

Seems the command here: https://github.com/aws/sagemaker-inference-toolkit/blob/master/src/sagemaker_inference/model_server.py#L83

Should change according to: https://github.com/awslabs/multi-model-server/blob/72e09f998874f5701404031441573e0eb6f2f866/mms/model_server.py#L20

To reproduce See above

Expected behavior No warning given

Screenshots or logs If applicable, add screenshots or logs to help explain your problem.

System information A description of your system.

Additional context Add any other context about the problem here.

chuyang-deng commented 4 years ago

Hi @mb-dev, thanks for pointing this out. The model server has renamed from mxnet-model-server to multi-model-server, and we will update the command, at the same time, contribution is welcomed.

jperuggia commented 9 months ago

This issue is pretty stale and appeared to have been addressed. any reason it is still open?