fix: add SIGCHILD Handler for MMS

dhanainme commented 3 years ago

MMS Worker processes are not cleared up upon Python SIGKILL in Docker env.

This fix adds SIGCHILD Handler for MMS to ensure the cleanup happens upon Model UnRegister.

Testing done:

Repeated Reg / UnReg on a container with this fix would not leave any Zombie processes

while true;
do
    curl -X POST "localhost:8080/models?url=https://s3.amazonaws.com/model-server/model_archive_1.0/squeezenet_v1.1.mar&initial_workers=3&synchronous=true"
    sleep 10
    curl -X DELETE "localhost:8080/models/squeezenet_v1.1"
    sleep 10
done

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

[x] I have read the CONTRIBUTING doc
[x ] I used the commit message format described in CONTRIBUTING
[x] I have used the regional endpoint when creating S3 and/or STS clients (if appropriate)
[x] I have updated any necessary documentation, including READMEs

Tests

[x] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[x] I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot commented 3 years ago

AWS CodeBuild CI Report

CodeBuild project: sagemaker-inference-toolkit-pr
Commit ID: ae61d2cfc2d27b7381b09238b2dae581860fbc6b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 3 years ago

AWS CodeBuild CI Report

CodeBuild project: sagemaker-inference-toolkit-pr
Commit ID: d180ceeea48a629ad70baab077ccb9dfe257c72d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 3 years ago

AWS CodeBuild CI Report

CodeBuild project: sagemaker-inference-toolkit-pr
Commit ID: 944836f9f27cbcb717f29eed08d34c3e670b389c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

dhanainme commented 3 years ago

Hi !

The build has been failing for Docker build for dependency resolution. Can someone take a look at this

INFO: pip is looking at multiple versions of sagemaker-inference to determine which version is compatible with other requirements. This could take a while.
INFO: pip is looking at multiple versions of gluonnlp to determine which version is compatible with other requirements. This could take a while.
INFO: pip is looking at multiple versions of aws-mxnet-mkl to determine which version is compatible with other requirements. This could take a while.
[91mERROR: Cannot install sagemaker-inference 1.2.2.dev0 (from /sagemaker_inference.tar.gz) and sagemaker-mxnet-inference==1.3.1.dev0 because these package versions have conflicting dependencies.
[0m
The conflict is caused by:
    The user requested sagemaker-inference 1.2.2.dev0 (from /sagemaker_inference.tar.gz)
    sagemaker-mxnet-inference 1.3.1.dev0 depends on sagemaker-inference<=1.2.0 and >=1.1.0

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict

[91mERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/user_guide/#fixing-conflicting-dependencies
[0mThe command '/bin/sh -c ${PIP} install --no-cache-dir     ${MX_URL}     git+git://github.com/dmlc/gluon-nlp.git@v0.9.0     multi-model-server==$MMS_VERSION     keras-mxnet==2.2.4.1     numpy==1.17.4     onnx==1.4.1     /sagemaker_mxnet_inference.tar.gz     /sagemaker_inference.tar.gz  && rm /sagemaker_mxnet_inference.tar.gz /sagemaker_inference.tar.gz' returned a non-zero code: 1

sagemaker-bot commented 3 years ago

AWS CodeBuild CI Report

CodeBuild project: sagemaker-inference-toolkit-pr
Commit ID: 944836f9f27cbcb717f29eed08d34c3e670b389c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 3 years ago

AWS CodeBuild CI Report

CodeBuild project: sagemaker-inference-toolkit-pr
Commit ID: 388bede354e66be9c2f237ee3f00d95ac91df24d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws / sagemaker-inference-toolkit