fix: remove call to deprecated function download_and_install - Githubissues

aws / sagemaker-mxnet-training-toolkit

Toolkit for running MXNet training scripts on SageMaker. Dockerfiles used for building SageMaker MXNet Containers are at https://github.com/aws/deep-learning-containers.

Apache License 2.0

60 stars 55 forks source link

fix: remove call to deprecated function download_and_install #132

Closed ajaykarpur closed 4 years ago

ajaykarpur commented 4 years ago

Description of changes:

The sagemaker-containers function modules.download_and_install() is deprecated and breaks network isolation.
The function modules.import_module() contains the necessary functionality to download, extract, and import the module without breaking network isolation. It also supports requirements.txt. modules.download_and_install() has been replaced with modules.import_module() accordingly.
The function entry_point.run() (which is called on the following line) contains some overlapping functionality with modules.import_module(), but it also runs the entry point. Upcoming work to refactor sagemaker-containers will remove redundant functionality and deprecated code.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot commented 4 years ago

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 4 years ago

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 4 years ago

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

ajaykarpur commented 4 years ago

Closing in favor of https://github.com/aws/sagemaker-containers/pull/246