search

aws / sagemaker-mxnet-training-toolkit

Toolkit for running MXNet training scripts on SageMaker. Dockerfiles used for building SageMaker MXNet Containers are at https://github.com/aws/deep-learning-containers.
Apache License 2.0
60 stars 55 forks source link

Readme out of date? #142

Closed AaronSpieler closed 4 years ago

AaronSpieler commented 4 years ago

The Readme says:

# All build instructions assume you're starting from the root directory of this repository

# MXNet 1.6.0, Python 3, CPU
$ cp dist/sagemaker_mxnet_container*.tar.gz docker/1.6.0/sagemaker_mxnet_container.tar.gz
$ cp -r docker/artifacts/* docker/1.6.0/py3
$ cd docker/1.6.0/py3
$ docker build -t preprod-mxnet:1.6.0-cpu-py3 -f Dockerfile.cpu .

However, there is no dist/sagemaker_mxnet_container*.tar.gz. I only get one that is called sagemaker_mxnet_training-3.1.12.dev0.tar.gz.

I just executed:

# Create the binary
git clone https://github.com/aws/sagemaker-mxnet-container.git
cd sagemaker-mxnet-container
python setup.py sdist

As the beginning of the Readme says to do.

laurenyu commented 4 years ago

looks like this was fixed in #154.