search

aws / sagemaker-mxnet-training-toolkit

Toolkit for running MXNet training scripts on SageMaker. Dockerfiles used for building SageMaker MXNet Containers are at https://github.com/aws/deep-learning-containers.
Apache License 2.0
60 stars 55 forks source link

Recycling old, unused files #175

Open ChaiBapchya opened 4 years ago

ChaiBapchya commented 4 years ago

Since the dockerfiles, tests have been migrated to https://github.com/aws/deep-learning-containers

We should clean up the redundant [and hence confusing] files such as

ChaiBapchya commented 4 years ago

@saimidu FYI

saimidu commented 4 years ago

Thanks @ChaiBapchya. All the redundant files will be deleted as soon as the migration of the dockerfiles for older framework versions is complete. Thank you for raising this issue.

chuyang-deng commented 4 years ago

Hi @ChaiBapchya, we will remove the DLC docker images once all existing container versions are migrated.

nadiaya commented 4 years ago

Hi,

We are still in the process of migration/separation plan of DLC and sagemaker toolkits that has been happening in the last few months.

We already cleaned up tests 10 days ago: https://github.com/aws/sagemaker-mxnet-training-toolkit/commit/4a647a964551f4ff3f3b920811b49f375c4c2e51

And, as part of the plan, will be keeping dockerfiles until all of them are fully migrated to the dlc repo. They have been put in read only mode and changes to the dockerfiles are no longer accepted on this repo.