search

aws / sagemaker-mxnet-training-toolkit

Toolkit for running MXNet training scripts on SageMaker. Dockerfiles used for building SageMaker MXNet Containers are at https://github.com/aws/deep-learning-containers.
Apache License 2.0
60 stars 55 forks source link

fix line length #29

Closed jesterhazy closed 6 years ago

jesterhazy commented 6 years ago

Issue #, if available:

n/a

Description of changes:

adjust line length to 100

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

jesterhazy commented 6 years ago

there is no flake config for this project, the build doesn't run flake, and the project has a significant number of other flake errors that aren't related to line length. i'd prefer not to boil the ocean on this PR.

jesterhazy commented 6 years ago

addressed (non-flake) pr comments.

laurenyu commented 6 years ago

if the build doesn't run flake, then it seems relatively harmless to go ahead and add a flake config. then future PRs can handle fixing the rest of the flake errors, and then we can add it to the build

jesterhazy commented 6 years ago

@nadiaya your requested change is done. can you approve to unblock the PR?