aws / sagemaker-mxnet-training-toolkit

Toolkit for running MXNet training scripts on SageMaker. Dockerfiles used for building SageMaker MXNet Containers are at https://github.com/aws/deep-learning-containers.
Apache License 2.0
60 stars 55 forks source link

build args to specify additional python packages and cuda version #32

Closed opringle closed 4 years ago

opringle commented 6 years ago

I'm no docker wizard but if this was possible then #31 could be achieved through modifying the build command, rather than creating new Dockerfiles.

Unsure how to implement but I imagine something like:

Build the base image docker build -t mxnet-base:1.2.1-gpu-py3 --build-arg cuda=9.2 -f Dockerfile.gpu .

Build the final image docker build -t mxnet-gluonnlp-cu92:1.2.1-gpu-py3 --build-arg cuda=9.2 --build-arg additional_packages=pandas,gluonnlp -f Dockerfile.gpu .

laurenyu commented 4 years ago

The Dockerfiles have now been moved to https://github.com/aws/deep-learning-containers