Fix MXNET_ENGINE_TYPE default

aws / sagemaker-mxnet-training-toolkit

Toolkit for running MXNet training scripts on SageMaker. Dockerfiles used for building SageMaker MXNet Containers are at https://github.com/aws/deep-learning-containers.

Apache License 2.0

60 stars 55 forks source link

Fix MXNET_ENGINE_TYPE default #69

Closed laurenyu closed 5 years ago

laurenyu commented 5 years ago

Description of changes: This value got incorrectly defined when the switch from SageMaker Container Support to SageMaker Containers happened

You can find acceptable values here: https://mxnet.incubator.apache.org/versions/master/faq/env_var.html#engine-type

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

laurenyu commented 5 years ago

@ChoiByungWook we do have a unit test for the main method that sets the environment variables, but testing the exact values of the default environment variables won't tell us much other than what we already hardcoded for ourselves. I guess I'm open to adding one but don't see much value in doing so.