Description of changes:
When a trn1 instance family is used, the PySDK would automatically use volume size argument when creating the endpoint config. However, this instance family does not support attaching an ebs volume, hence volume size argument throws a service exception. This PR updates the volume_size_supported function to correctly identify trn1 instance types as not supporting volume size.
Testing done:
Unit tests added.
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
[ ] I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
[ ] I used the commit message format described in CONTRIBUTING
[ ] I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
[ ] I have updated any necessary documentation, including READMEs and API docs (if appropriate)
Tests
[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ ] I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
[ ] I have checked that my tests are not configured for a specific region or account (if appropriate)
[ ] I have used unique_name_from_base to create resource names in integ tests (if appropriate)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue #, if available:
Description of changes: When a
trn1instance family is used, the PySDK would automatically use volume size argument when creating the endpoint config. However, this instance family does not support attaching an ebs volume, hence volume size argument throws a service exception. This PR updates thevolume_size_supportedfunction to correctly identifytrn1instance types as not supporting volume size.Testing done: Unit tests added.
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.