Open lorenzwalthert opened 1 month ago
Is there anything holding up removal of the pin? From a quick scan, I would think it is basically a few tiny replacements for things like np.NaN
which ruff check path/to/code/ --select NPY201 --fix
will just do.
There are a few uses np.int
which might be fishy if (and only if!) this code ever runs on windows (otherwise, it may be fishy, but there is no change in NumPy 2).
@ellisonbg do you know who we should talk to about NumPy 2 support here?
Any status on this when we could expect this support to be added?
Describe the feature you'd like In June 2024, numpy 2.0.0 was released.
sagemaker-python-sdk
depends onnumpy>=1.9.0,<2.0
. This creates a dependency hell for me, as I have dependencies in my python package that depend onnumpy >= 2.0.0
.You could either enforce
numpy >= 2.0.0
and make new releases of the package incompatible withnumpy < 2.0.0
or keep supporting the currently supportednumpy
versions, but also add those>= 2.0.0
. I.e. depending on whether or not there are breaking changes withnumpy >= 2.0.0
in your code base, establish different code paths depending on the installed version ofnumpy
.How would this feature be used? Please describe.
Ensuring I can resolve dependencies in Python packages that have both this SDK as well as other dependencies with a requirement for
numpy >= 2.0
.Describe alternatives you've considered
I don't think there is an alternative, as in the long run, this problem will get worse as more and more other packages depend on
numpy >= 2.0.0
. I am surprised no one has opened an issue for now.Additional context I am also opening a support case with AWS Premium Support.