aws / sagemaker-python-sdk

A library for training and deploying machine learning models on Amazon SageMaker
https://sagemaker.readthedocs.io/
Apache License 2.0
2.1k stars 1.14k forks source link

fix: fixing typo in dependency setup #4905

Closed akrishna1995 closed 1 month ago

akrishna1995 commented 1 month ago

charset-normalizer is misplet in the requirements.txt files

Issue #, if available:

Description of changes:

Testing done:

run tox locally for UTs

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

akrishna1995 commented 1 month ago

how did the old code even work ? Maybe this package is not even needed. Lets start a parallel thread with the original author to understand how this code path is tested.

Good question - The dependency must be pulled as part of another package in the requirements.txt file, pip always tries to pull the latest compatible version which would be 3.4, so I'm guessing that's why no issues ( maybe there is an open issue for a particular component)

pip clearly mentions error when installing, I'm guessing this was missed by original creators - will follow up with the team and add a CR checklist as well meanwhile.

 % pip install packagedoesnotexist
ERROR: Could not find a version that satisfies the requirement packagedoesnotexist (from versions: none)
ERROR: No matching distribution found for packagedoesnotexist