fix: raises error when a regression is given a batch with no numerics

ipanepen commented 4 years ago

This commit raises an error when non_nan_indices is empty. There will only be nan values in the target column during regression, because nan values will be converted into labels for other problem types. During regression, all non-numerics in the target column will be turned into nan values and their rows will be dropped. If all the values in the batch are not numeric, all of the rows will be dropped and the feature transformer will fail. This raises an error before that happens.

Issue #, if available:

Description of changes:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

[x] I have read the CONTRIBUTING doc
[x] I used the commit message format described in CONTRIBUTING
[x] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ ] I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

wiltonwu commented 4 years ago

AWS CodeBuild CI Report

CodeBuild project: sagemaker-sklearn-extension-pr
Commit ID: fa33af3369a43876175b47ce1edb753466afb435
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

wiltonwu commented 4 years ago

AWS CodeBuild CI Report

CodeBuild project: sagemaker-sklearn-extension-pr
Commit ID: 1bae1881c13cb6b76888c1426d64d53b489a9eb7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws / sagemaker-scikit-learn-extension