aws / sagemaker-scikit-learn-extension

A library of additional estimators and SageMaker tools based on scikit-learn
Apache License 2.0
39 stars 33 forks source link

fix: makes fit_transform behavior consistent with fit and transform #18

Closed ipanepen closed 4 years ago

ipanepen commented 4 years ago

The behavior of fit_transform was inconsistent with behavior of fit and transform run sequentially. It should be possible to use fit_transform for the normal functionality of RobustLabelEncoder (filling unseen values). I modified already existing tests, and created a new one to ensure the behavior is as expected.

Issue #, if available:

Description of changes:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

wiltonwu commented 4 years ago

AWS CodeBuild CI Report

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository