Use js_import instead of js_include - Githubissues

aws / sagemaker-tensorflow-serving-container

A TensorFlow Serving solution for use in SageMaker. This repo is now deprecated.

Apache License 2.0

174 stars 101 forks source link

Use js_import instead of js_include #217

Closed satishpasumarthi closed 2 years ago

satishpasumarthi commented 2 years ago

Issue #, if available: The njs function js_include has been obsolete starting njs v0.7.1 http://nginx.org/en/docs/http/ngx_http_js_module.html#js_include

Upgraded the code to use js_import in place of js_include which requires few changes to the nginx.conf.template and the naming of .js file. (described below)

Description of changes:

Updated nginx.conf.template to use js_import instead of js_include
Renamed tensorflow-serving.js to tensorflowServing.js
Updated nginx.conf.template to use export definitions for the functions
Fixed pylint errors by passing utf-8 encoding while opening a file
Fixed jshint errors by adding esversion: 6 to .jshlintrc file. The export statement is available only from es6
Pull Ubuntu16.04 docker image from ECR rather than ubuntu to avoid docker pull limit failures

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot commented 2 years ago

AWS CodeBuild CI Report

CodeBuild project: sagemaker-tensorflow-serving-container-pr
Commit ID: ac6b43a640f29c714f7b42c737eeb359fa6fba54
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 years ago

AWS CodeBuild CI Report

CodeBuild project: sagemaker-tensorflow-serving-container-pr
Commit ID: e35158a4e09d2a9da2d099d967156d5af971616c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 years ago

AWS CodeBuild CI Report

CodeBuild project: sagemaker-tensorflow-serving-container-pr
Commit ID: f55e934c578c328281445ed866dccae3e2f5f7b0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 years ago

AWS CodeBuild CI Report

CodeBuild project: sagemaker-tensorflow-serving-container-pr
Commit ID: f55e934c578c328281445ed866dccae3e2f5f7b0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 years ago

AWS CodeBuild CI Report

CodeBuild project: sagemaker-tensorflow-serving-container-pr
Commit ID: 4637a3a15a161d70938164af05093222bd5aabe4
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 years ago

AWS CodeBuild CI Report

CodeBuild project: sagemaker-tensorflow-serving-container-pr
Commit ID: 07a6bc982a87a220141a68bc439227fade36e43b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 years ago

AWS CodeBuild CI Report

CodeBuild project: sagemaker-tensorflow-serving-container-pr
Commit ID: f55e934c578c328281445ed866dccae3e2f5f7b0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 years ago

AWS CodeBuild CI Report

CodeBuild project: sagemaker-tensorflow-serving-container-pr
Commit ID: d831c9179a9b9b93c10f02ad728068880254b47e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 years ago

AWS CodeBuild CI Report

CodeBuild project: sagemaker-tensorflow-serving-container-pr
Commit ID: 997d0209675c576d19686186453aa83cb9c87457
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 years ago

AWS CodeBuild CI Report

CodeBuild project: sagemaker-tensorflow-serving-container-pr
Commit ID: 81254bf6c53daa7b7a24308af90b0f03013f95d8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 years ago

AWS CodeBuild CI Report

CodeBuild project: sagemaker-tensorflow-serving-container-pr
Commit ID: cee22d6e2b3df382eefdceadb40de71e35fcf7bf
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 years ago

AWS CodeBuild CI Report

CodeBuild project: sagemaker-tensorflow-serving-container-pr
Commit ID: ff86d85e630da862e1600f0ed0cfb1792f66fcab
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 years ago

AWS CodeBuild CI Report

CodeBuild project: sagemaker-tensorflow-serving-container-pr
Commit ID: 6bd1269c5fae038d389e420182c106e66d811e85
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 years ago

AWS CodeBuild CI Report

CodeBuild project: sagemaker-tensorflow-serving-container-pr
Commit ID: 6bd1269c5fae038d389e420182c106e66d811e85
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 years ago

AWS CodeBuild CI Report

CodeBuild project: sagemaker-tensorflow-serving-container-pr
Commit ID: 6bd1269c5fae038d389e420182c106e66d811e85
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 years ago

AWS CodeBuild CI Report

CodeBuild project: sagemaker-tensorflow-serving-container-pr
Commit ID: 6bd1269c5fae038d389e420182c106e66d811e85
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 years ago

AWS CodeBuild CI Report

CodeBuild project: sagemaker-tensorflow-serving-container-pr
Commit ID: 34f5cf4f0273757107cf700976f323ce02f1bdca
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 years ago

AWS CodeBuild CI Report

CodeBuild project: sagemaker-tensorflow-serving-container-pr
Commit ID: 34f5cf4f0273757107cf700976f323ce02f1bdca
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 2 years ago

AWS CodeBuild CI Report

CodeBuild project: sagemaker-tensorflow-serving-container-pr
Commit ID: f0b050cedb6b23fe96f99491411ebfb2b9a012fa
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

satishpasumarthi commented 2 years ago

@tejaschumbalkar @josephevans Could you please review the PR changes?