feature: smdataparallel enable EFA RDMA flag

karan6181 commented 3 years ago

Description of changes:

Enabled the EFA's RDMA functionality for one-sided and two-sided transfer for ml.p4d.24xlarge instances.

Testing done:

Ran the smdataparallel unit test
Ran the TF2+MNIST smdataparallel jupyter notebook on p3.16xlarge and p4d.24xlarge, both ran successfully.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

[x] I have read the CONTRIBUTING doc
[x] I used the commit message format described in CONTRIBUTING
[ ] I have used the regional endpoint when creating S3 and/or STS clients (if appropriate)
[ ] I have updated any necessary documentation, including READMEs

Tests

[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ ] I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot commented 3 years ago

AWS CodeBuild CI Report

CodeBuild project: sagemaker-training-toolkit-pr
Commit ID: c909ac68fed49cbc5d0cd7a14104c88f37b6fb7e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot commented 3 years ago

AWS CodeBuild CI Report

CodeBuild project: sagemaker-training-toolkit-pr
Commit ID: 0b90e09fa239f06b48dbffc69b40dd649aecced0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

karan6181 commented 3 years ago

Ran the TF2+MNIST smdataparallel jupyter notebook on p3.16xlarge and p3dn.24xlarge, both ran successfully.
For p3dn.24xlarge instance, it adds -x FI_EFA_USE_DEVICE_RDMA=1 to the mpirun command and for p3.16xlarge instance, it's not, which is expected.
Attached the jupyter notebook zip file for the same smdataparallel_TF2_mnist_rdma_flag.zip

sagemaker-bot commented 3 years ago

AWS CodeBuild CI Report

CodeBuild project: sagemaker-training-toolkit-pr
Commit ID: 07cb410433a4ef4cc3a534548c7ae07c83b54198
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws / sagemaker-training-toolkit