Relying on potentially uninitialized environment variables.

[nadiaya]

• https://github.com/aws/sagemaker-containers/blob/be2ac3746e0afeceb53d2f91261d1586ff290cfc/src/sagemaker_containers/_files.py#L156
• https://github.com/aws/sagemaker-containers/blob/0c0bfcd4afa54f2a7fd71ba6d5c814a692a636f0/src/sagemaker_containers/_trainer.py#L73

os.environ.get('AWS_REGION', os.environ.get(_params.REGION_NAME_ENV))

I don't think 'AWS_REGION' is set the platform in Training. Looks like 'REGION_NAME_ENV' can be used independently but in reality it gets set when training environment is initialized.

[yangaws]

Hi @mvsusp,

Seems you made the change, do you have an answer for this?

[mvsusp]

The training environment set's the region here https://github.com/aws/sagemaker-containers/blob/master/src/sagemaker_containers/_env.py#L554

This code is more complicated that it should be. I would:

• create a property region in the training environment
• add an optional parameter region in the s3 download function