Description of changes:
Was experiencing an issue where an exception was raised in the asyncio subprocess shell but the process was reporting the return code as 0. This modifies the run_async function to make use of process.wait which should ensure the process is completely finished and the correct return code is returned.
Testing done:
All unit and formatting test cases passed.
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
Description of changes: Was experiencing an issue where an exception was raised in the asyncio subprocess shell but the process was reporting the return code as 0. This modifies the
run_async
function to make use of process.wait which should ensure the process is completely finished and the correct return code is returned.Testing done: All unit and formatting test cases passed.
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.