aws / sagemaker-training-toolkit

Train machine learning models within a 🐳 Docker container using 🧠 Amazon SageMaker.
Apache License 2.0
496 stars 118 forks source link

fix: Removed version hardcoding for sagemaker test dependency #141

Closed jleeleee closed 2 years ago

jleeleee commented 2 years ago

Issue #, if available: N/A

Description of changes: Hardcoding the older version of the sagemaker-python-sdk required additional IAM policies to be able to access the default sagemaker bucket in tests. This change removes the hardcoding so that tests can be run with the most recent sagemaker version

Testing done: Re-confirmed using tox -e py38 -- test/functional

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot commented 2 years ago

AWS CodeBuild CI Report

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository